New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Cable: Defer starting connection monitor until a connection is opened #24038

Merged
merged 1 commit into from Mar 4, 2016

Conversation

Projects
None yet
5 participants
@javan
Member

javan commented Mar 4, 2016

Fixes issue mentioned by @matthewd in #24026 (comment):

Incidentally, I believe there's an issue with the current behaviour anyway: it still seems to connect without any subscription defined / data sent. I'm guessing the auto-reconnect behaviour in the connection manager is still kicking in.

Refactored / cleaned up ConnectionMonitor a bit leaving the reconnect logic unchanged.

/cc @jeremy (since you merged my last PR 馃榿)

@rails-bot

This comment has been minimized.

rails-bot commented Mar 4, 2016

r? @rafaelfranca

(@rails-bot has picked a reviewer for you, use r? to override)

jeremy added a commit that referenced this pull request Mar 4, 2016

Merge pull request #24038 from javan/actioncable-lazy-connection-monitor
Action Cable: Defer starting connection monitor until a connection is opened

@jeremy jeremy merged commit f8ec3a1 into rails:master Mar 4, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment