New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Cable: Return subscription object(s) when updating the collection #24057

Merged
merged 1 commit into from Mar 4, 2016

Conversation

Projects
None yet
6 participants
@javan
Member

javan commented Mar 4, 2016

Re: f1c93ed#commitcomment-16501663

I think ActionCable.Subscriptions#create should always return the Subscription object. We expect that in our apps as well.

Slightly improved version of 9ce6fe4

/cc @lifo @jeremy

@rails-bot

This comment has been minimized.

rails-bot commented Mar 4, 2016

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

@javan javan changed the title from Return subscription object(s) when updating the collection to Action Cable: Return subscription object(s) when updating the collection Mar 4, 2016

@sgrif

This comment has been minimized.

Member

sgrif commented Mar 4, 2016

r? @lifo

@jeremy

This comment has been minimized.

Member

jeremy commented Mar 4, 2016

🙌

jeremy added a commit that referenced this pull request Mar 4, 2016

Merge pull request #24057 from javan/actioncable-return-subscription
Action Cable: Return subscription object(s) when updating the collection

@jeremy jeremy merged commit 7b96d86 into rails:master Mar 4, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment