Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix `thread_mattr_accessor` thread-local variable naming #24143
I believe there's an oopsie in the current implentation of
At this point
A comparison test has been added (we're already testing the setters above), and all AS tests are passing.
Please scrutinize. :)
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
"1 failing check" != "All checks have failed"
This was developed on Ruby 2.3.0 and I see the build issue was specifically with 2.2.4 with
By using Faye (
The error's always a variant of:
(A number of tests call
This points to
If so, it's a separate issue (and should probably be submitted as such), but I believe that's what the Travis build failure above was about.
To reproduce, try:
3-5x or so...