New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_join_table should work with uuid #24221

Merged
merged 1 commit into from Apr 20, 2016

Conversation

Projects
None yet
6 participants
@gregmolnar
Member

gregmolnar commented Mar 17, 2016

create_join_table had integers hardcoded for the column type, but I think it should support other column types such as uuid too.

@rails-bot

This comment has been minimized.

rails-bot commented Mar 17, 2016

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

@gregmolnar gregmolnar force-pushed the gregmolnar:uuid branch to 62c01d3 Mar 17, 2016

@pinak1180

This comment has been minimized.

pinak1180 commented Mar 17, 2016

i agree with @gregmolnar till now,we need to create join table manually

@gregmolnar

This comment has been minimized.

Member

gregmolnar commented Mar 24, 2016

Did anyone had a chance to review this?

@gregmolnar

This comment has been minimized.

Member

gregmolnar commented Apr 20, 2016

r? @kaspth

@rails-bot rails-bot assigned kaspth and unassigned sgrif Apr 20, 2016

@kaspth kaspth merged commit 3ff6b80 into rails:master Apr 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kaspth

This comment has been minimized.

Member

kaspth commented Apr 20, 2016

Thanks, @gregmolnar! You might have just made your own newsletter 😄

@gregmolnar

This comment has been minimized.

Member

gregmolnar commented Apr 21, 2016

@kaspth Thanks for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment