New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show error message when error raised in rails runner #24260

Merged
merged 1 commit into from Aug 7, 2016

Conversation

Projects
None yet
6 participants
@y-yagi
Member

y-yagi commented Mar 21, 2016

Error message is no longer displays in #22938.
However, error message with help of error of the investigation I think.

@rails-bot

This comment has been minimized.

rails-bot commented Mar 21, 2016

r? @matthewd

(@rails-bot has picked a reviewer for you, use r? to override)

@maclover7 maclover7 added the railties label Mar 21, 2016

@y-yagi y-yagi force-pushed the y-yagi:show_error_message_when_error_raised_in_rails_runner branch Mar 30, 2016

@y-yagi y-yagi force-pushed the y-yagi:show_error_message_when_error_raised_in_rails_runner branch May 22, 2016

@chuckd

This comment has been minimized.

chuckd commented Aug 3, 2016

It would be brilliant if this could be merged @y-yagi . Perhaps you could update to merge on master? I just got stumped by this error swallowing behaviour of the Rails 5 runner - my script had a NameError inside it (not the command itself) but all runner told me was

Please specify a valid ruby command or the path of a script to run

@y-yagi y-yagi force-pushed the y-yagi:show_error_message_when_error_raised_in_rails_runner branch Aug 3, 2016

@y-yagi y-yagi force-pushed the y-yagi:show_error_message_when_error_raised_in_rails_runner branch to bf71b6a Aug 3, 2016

@y-yagi

This comment has been minimized.

Member

y-yagi commented Aug 3, 2016

@chuckd Thanks for notice! I rebased with master.

@kaspth kaspth merged commit 33ec865 into rails:master Aug 7, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate Code Climate didn't find any new or fixed issues.
Details
@kaspth

This comment has been minimized.

Member

kaspth commented Aug 7, 2016

Thanks @y-yagi!

kaspth added a commit that referenced this pull request Aug 7, 2016

Merge pull request #24260 from y-yagi/show_error_message_when_error_r…
…aised_in_rails_runner

show error message when error raised in rails runner
@kaspth

This comment has been minimized.

Member

kaspth commented Aug 7, 2016

5-0-stable: d8a08e9

@y-yagi

This comment has been minimized.

Member

y-yagi commented Aug 7, 2016

Thanks!

@y-yagi y-yagi deleted the y-yagi:show_error_message_when_error_raised_in_rails_runner branch Aug 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment