New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Range#cover? for Date inclusion validator #24297

Merged
merged 2 commits into from Mar 24, 2016

Conversation

Projects
None yet
5 participants
@ojab
Contributor

ojab commented Mar 24, 2016

AFAICS Range#cover? works just fine for Date in ruby-2.2/2.3, jruby-9k & rbx, so let's use it.
Please advise if I'm missing something.

@rails-bot

This comment has been minimized.

rails-bot commented Mar 24, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit 0741cf9 into rails:master Mar 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment