Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rails restart issue with Puma #24331

Merged
merged 1 commit into from Mar 30, 2016

Commits on Mar 30, 2016

  1. Fix rails restart issue with Puma

    - We need to pass the restart command to Puma so that it will use it
      while restarting the server.
    - Also made sure that all the options passed by user while starting
      the server are used in the generated restart command so that they will
      be used while restarting the server.
    - Besides that we need to remove the server.pid file for the previous running
      server because otherwise Rack complains about it's presence.
    - We don't care if the server.pid file does not exist. We only want to delete
      it if it exists.
    - This also requires some changes on Puma side which are being tracked
      here - puma/puma#936.
    - Fixes rails#23910.
    prathamesh-sonpatki committed Mar 30, 2016
    Copy the full SHA
    9d87ce3 View commit details
    Browse the repository at this point in the history