New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sendmail default arguments match Mail::SendMail #24436

Merged
merged 1 commit into from Apr 6, 2016

Conversation

Projects
None yet
4 participants
@arktisklada
Contributor

arktisklada commented Apr 5, 2016

Resolves #1755

A while back, Mail::Sendmail was updated to remove the -t argument, and this intends to update Rails accordingly.

References:

@rails-bot

This comment has been minimized.

rails-bot commented Apr 5, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@arktisklada arktisklada force-pushed the arktisklada:matching-sendmail-default-arguments branch Apr 5, 2016

@arktisklada arktisklada force-pushed the arktisklada:matching-sendmail-default-arguments branch to 23e4c96 Apr 5, 2016

@rafaelfranca rafaelfranca merged commit ff982e4 into rails:master Apr 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Apr 6, 2016

Thank you

@arktisklada

This comment has been minimized.

Contributor

arktisklada commented Apr 6, 2016

@rafaelfranca should this possibly be backported to the rails 4.2 stable branch too?

@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Apr 7, 2016

Done in 2a1b655

rafaelfranca added a commit that referenced this pull request Apr 7, 2016

Merge pull request #24436 from arktisklada/matching-sendmail-default-…
…arguments

Sendmail default arguments match Mail::SendMail

y-yagi added a commit to y-yagi/rails that referenced this pull request Jul 6, 2016

y-yagi added a commit to y-yagi/rails that referenced this pull request Jul 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment