New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Action Cable callbacks through the worker pool #24540

Merged
merged 1 commit into from Apr 14, 2016

Conversation

Projects
None yet
4 participants
@sgrif
Member

sgrif commented Apr 13, 2016

Alternate implementation of #24162 with tests. The code had diverged
too far on master to pull that implemenation directly.

Fixes #23778
Close #24162

r? @matthewd @jeremy

Run Action Cable callbacks through the worker pool
Alternate implementation of #24162 with tests. The code had diverged
too far on master to pull that implemenation directly.

Fixes #23778
Close #24162

[Mattew Draper & Sean Griffin]

@sgrif sgrif assigned jeremy and unassigned matthewd Apr 13, 2016

@sgrif sgrif added this to the 5.0.0 milestone Apr 13, 2016

@jeremy

This comment has been minimized.

Member

jeremy commented Apr 14, 2016

Looks good to me.

@jeremy jeremy assigned matthewd and unassigned jeremy Apr 14, 2016

@sgrif sgrif merged commit 4769fc4 into rails:master Apr 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sgrif sgrif deleted the sgrif:sg-actioncable-callbacks branch Apr 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment