New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added irregular zombie inflection, so zombies != zomby #2457

Merged
merged 1 commit into from Aug 7, 2011

Conversation

Projects
None yet
9 participants
@Gregg
Copy link
Contributor

Gregg commented Aug 7, 2011

Over 50k people have received their first taste of Rails by playing through "Rails for Zombies" (http://railsforzombies.org). Only problem is when they start to play around using a zombie scaffold:

rails generate scaffold zombie name:string

This generates controller which improperly singularizes zombies, so the instance variables are all @zomby. As a side-effect of this form attributes don't work. The parameters properly send "zombie"=>{"name"=>"test"}", but the controller is looking for params[:zomby].

For the sake of new people trying to learn Rails who email me wondering why their first app doesn't work, and... well.. for the sake of the zombies, can we fix this tragedy?

Zombies were people too

fxn added a commit that referenced this pull request Aug 7, 2011

Merge pull request #2457 from Gregg/zombie_singular_fix
Added irregular zombie inflection, so zombies != zomby

@fxn fxn merged commit e06db72 into rails:master Aug 7, 2011

@nicolasblanco

This comment has been minimized.

Copy link
Contributor

nicolasblanco commented on 554232e Aug 7, 2011

I totally disagree this commit! This is just a machiavelian plan from @Gregg to insert the word zombies directly into Rails! Don't listen to him, he's one of them!
:-D

@nbibler

This comment has been minimized.

Copy link
Contributor

nbibler commented Aug 7, 2011

Our plan is working! ;)

@stevenhaddox

This comment has been minimized.

Copy link

stevenhaddox commented Aug 10, 2011

best. commit. evar.

@Optimiza

This comment has been minimized.

Copy link

Optimiza commented Aug 10, 2011

OMG Gregg, and also thanks goes to LH guy for merge it.

@mauriciodeamorim

This comment has been minimized.

Copy link

mauriciodeamorim commented Aug 11, 2011

Interesting and hilarious, you do not miss the opportunity to make a joke. The outgoing side of the world Ruby on Rails is pretty cool. Very good! Congratulations!

@DaveCollinsJr

This comment has been minimized.

Copy link

DaveCollinsJr commented Aug 12, 2011

Yet one more reason why Rails is THE BOMB!

@s2k

This comment has been minimized.

Copy link

s2k commented Aug 12, 2011

Very funny indeed. Thanks Gregg & fan. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment