New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Change 1.week to create 1 week durations instead of 7 days durations. #24762

Merged
merged 1 commit into from Apr 29, 2016

Conversation

Projects
None yet
5 participants
@Envek
Contributor

Envek commented Apr 28, 2016

Retry of #22806.

Fixes regression with datatype conversions when doing math with durations and times found by @jeremy at #22806 (comment) with solution proposed by @pixeltrix at #22806 (comment)

Test to prevent such regression in future is included.

r? @jeremy
/cc @pixeltrix

Change 1.week to create 1 week durations instead of 7 days durations.
This is just to remove astonishment from getting `3600 seconds` from typing `1.hour`.
@vipulnsward

This comment has been minimized.

Member

vipulnsward commented Apr 28, 2016

This fixes build failures.

@pixeltrix pixeltrix merged commit f0a6cce into rails:master Apr 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pixeltrix

This comment has been minimized.

Member

pixeltrix commented Apr 29, 2016

@Envek thanks for responding quickly 👍

jeremy added a commit that referenced this pull request Apr 29, 2016

AS::Duration changelog polish
Use the updated changelog from the first merge: 7254517

References #22806, #24762.

[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment