Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature getting started guide #24942

Merged
merged 1 commit into from May 9, 2016

Conversation

bvsatyaram
Copy link
Contributor

Summary

Fixed few grammar issues in Getting Started guide.

Other Information

This is my first commit to Rails. Probably this would be a good start. Please excuse me for the silly changes, which don't have much of value additions apart from a simple addition of sugar.

Thanks!

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@vipulnsward
Copy link
Member

@bvsatyaram this still has an extra commit- 09d7091
Can you remove that?

@bvsatyaram bvsatyaram force-pushed the feature-getting-started-guide branch from 29dd1c4 to 95f7629 Compare May 9, 2016 19:57
@bvsatyaram
Copy link
Contributor Author

@vipulnsward
I removed the merge commit. Never used rebase earlier. Thanks for the patience and sorry for the inconvenience.

@vipulnsward vipulnsward merged commit d7e4083 into rails:master May 9, 2016
@vipulnsward
Copy link
Member

Thanks @bvsatyaram !

@maclover7 maclover7 added the docs label May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants