Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mysql and sqlite3 default test #25097

Closed

Conversation

kenjiszk
Copy link
Contributor

Summary

Extend database default value test for mysql and sqlite3.

Other Information

MySQL text type cannot be assigned a default value. So it is skipped.
http://dev.mysql.com/doc/refman/5.6/en/data-type-defaults.html

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rafaelfranca
Copy link
Member

MySQL tests are broken.

@kenjiszk
Copy link
Contributor Author

kenjiszk commented Jun 6, 2016

@rafaelfranca
I changed the order of base_test, then test recovered. Is there test execution order in active record test? or Am I doing some wrong cording?

@arthurnn
Copy link
Member

arthurnn commented Jun 6, 2016

can you also test if this works with: bin/test -a mysql2

@kenjiszk
Copy link
Contributor Author

@arthurnn @rafaelfranca
Thank you for comment. I have revealed the cause issue. The test of "schema_dumper_test.rb" created and dropped a "defaults" table and it affect on test of "base_test.rb". So, it was succeeded when changing test order. I change table name of schema dump test from "defaults" to "dump_defaults". Could you please check this?

@arthurnn
Copy link
Member

arthurnn commented Jan 3, 2017

do you mind rebasing this, and I will give it a final look and 🍏 it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants