-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display railtie class name in rails initializers
#25257
Conversation
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Not comfortable relying on an |
198c62c
to
116f7a1
Compare
@schneems Thanks. I've updated with your advise. |
Looks better, can you add a test, then I think we're looking good to move forwards. |
I've changed implementation. Old one expected that |
@schneems Anything else I need to add to this? |
I'm fine with this. Thanks! |
- Also minor weekly CHANGELOG cleanup.
…nitializers CHANGELOG for #25257 [ci skip]
Summary
I add a class name to recognize same macro name like
load_config_initializers
andload_environment_config
etc inrails initializers
.