New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display railtie class name in `rails initializers` #25257

Merged
merged 3 commits into from Jul 5, 2016

Conversation

Projects
None yet
4 participants
@ta1kt0me
Contributor

ta1kt0me commented Jun 2, 2016

Summary

I add a class name to recognize same macro name like load_config_initializers and load_environment_config etc in rails initializers.

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Jun 2, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rails-bot commented Jun 2, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@maclover7 maclover7 added the railties label Jun 3, 2016

@schneems

This comment has been minimized.

Show comment
Hide comment
@schneems

schneems Jun 7, 2016

Member

Not comfortable relying on an instance_variable_get(:@context) in this case. Is there no public interface for this info? Could we add one?

Member

schneems commented Jun 7, 2016

Not comfortable relying on an instance_variable_get(:@context) in this case. Is there no public interface for this info? Could we add one?

@ta1kt0me

This comment has been minimized.

Show comment
Hide comment
@ta1kt0me

ta1kt0me Jun 10, 2016

Contributor

@schneems Thanks. I've updated with your advise.

Contributor

ta1kt0me commented Jun 10, 2016

@schneems Thanks. I've updated with your advise.

@schneems

This comment has been minimized.

Show comment
Hide comment
@schneems

schneems Jun 10, 2016

Member

Looks better, can you add a test, then I think we're looking good to move forwards.

Member

schneems commented Jun 10, 2016

Looks better, can you add a test, then I think we're looking good to move forwards.

@ta1kt0me

This comment has been minimized.

Show comment
Hide comment
@ta1kt0me

ta1kt0me Jun 12, 2016

Contributor

I've changed implementation. Old one expected that @context is always Rails::Railtie's subclass. I thought it's no problem because initializer method bases Rails::Railtie. But it wasn't modulability. I only want to know a class which defineds initializer in this PR, then I've defined new interface. Please tell me if we need rebase it.

Contributor

ta1kt0me commented Jun 12, 2016

I've changed implementation. Old one expected that @context is always Rails::Railtie's subclass. I thought it's no problem because initializer method bases Rails::Railtie. But it wasn't modulability. I only want to know a class which defineds initializer in this PR, then I've defined new interface. Please tell me if we need rebase it.

@ta1kt0me

This comment has been minimized.

Show comment
Hide comment
@ta1kt0me

ta1kt0me Jul 5, 2016

Contributor

@schneems Anything else I need to add to this?

Contributor

ta1kt0me commented Jul 5, 2016

@schneems Anything else I need to add to this?

@schneems

This comment has been minimized.

Show comment
Hide comment
@schneems

schneems Jul 5, 2016

Member

I'm fine with this. Thanks!

Member

schneems commented Jul 5, 2016

I'm fine with this. Thanks!

@schneems schneems merged commit 67d5783 into rails:master Jul 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ta1kt0me ta1kt0me deleted the ta1kt0me:inspect_initializers branch Jul 6, 2016

prathamesh-sonpatki added a commit to prathamesh-sonpatki/rails that referenced this pull request Jul 17, 2016

CHANGELOG for rails#25257 [ci skip]
- Also minor weekly CHANGELOG cleanup.

rafaelfranca added a commit that referenced this pull request Jul 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment