Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Broadcast #silence on ActiveSupport::Logger #25341
I pulled in
I found that in our rails app it would silence the asset requests correctly into
The reason for this is that we use broadcasting to delegate the logged message to both the console and the log file. But without delegating the call to
The broadcasting module needs to properly delegate
Also took the opportunity to rewrite the tests entirely, increase coverage, and properly test
Not sure what the release path is for this. The quiet assets feature fails to work without this fix.
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @chancancode (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.