Add config.assets.quiet = true as default for generator #25351

Merged
merged 1 commit into from Jun 10, 2016

Projects

None yet

5 participants

@kmcphillips
Contributor

@rafaelfranca @sgrif @wvanbergen
Paired with @jonathankwok

Sets the config.assets.quiet to true by default, and explicitly in the generator.

From rails/sprockets-rails#355, but also related to #25341 to work properly.

This depends on sprockets-rails being released and bumped to the newest version. I'm not sure how we manage that dependency. Worst case it's a property set on the Sprockets::Railtie::OrderedOptions instance config that does nothing. But it's pretty unclear to define a noop property.

@senny senny was assigned by rails-bot Jun 10, 2016
@rails-bot

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rafaelfranca
Member

It is totally fine to define a noop for now. I'll release a new version of sprockets-rails sometime next week.

@rafaelfranca rafaelfranca merged commit ee7de7d into rails:master Jun 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmcphillips kmcphillips added a commit to kmcphillips/rails that referenced this pull request Jun 23, 2016
@kmcphillips kmcphillips Update changelog for #25351 2ffa001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment