New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config.assets.quiet = true as default for generator #25351

Merged
merged 1 commit into from Jun 10, 2016

Conversation

Projects
None yet
5 participants
@kmcphillips
Contributor

kmcphillips commented Jun 10, 2016

@rafaelfranca @sgrif @wvanbergen
Paired with @jonathankwok

Sets the config.assets.quiet to true by default, and explicitly in the generator.

From rails/sprockets-rails#355, but also related to #25341 to work properly.

This depends on sprockets-rails being released and bumped to the newest version. I'm not sure how we manage that dependency. Worst case it's a property set on the Sprockets::Railtie::OrderedOptions instance config that does nothing. But it's pretty unclear to define a noop property.

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Jun 10, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rails-bot commented Jun 10, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Jun 10, 2016

Member

It is totally fine to define a noop for now. I'll release a new version of sprockets-rails sometime next week.

Member

rafaelfranca commented Jun 10, 2016

It is totally fine to define a noop for now. I'll release a new version of sprockets-rails sometime next week.

@rafaelfranca rafaelfranca merged commit ee7de7d into rails:master Jun 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request Jun 10, 2016

Merge pull request #25351 from kmcphillips/asset-default-config-quiet
Add config.assets.quiet = true as default for generator

kmcphillips added a commit to kmcphillips/rails that referenced this pull request Jun 23, 2016

claudiob added a commit to claudiob/rails that referenced this pull request Mar 21, 2017

Move CHANGELOG entry from 5-1 to 5-0 [ci skip]
The entry in the CHANGELOG refers to #25351 which was merged into
Rails 5.0. The behavior did not change in Rails 5.1.

See discussion at rails@2ffa001#commitcomment-21410869

claudiob added a commit to claudiob/rails that referenced this pull request Mar 21, 2017

Move CHANGELOG entry to 5-0 from 5-1 [ci skip]
The entry in the CHANGELOG refers to #25351 which was merged into
Rails 5.0. The behavior did not change in Rails 5.1.

See discussion at rails@2ffa001#commitcomment-21410869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment