Join GitHub today
Fix rails/info routes for apps with globbing route #25430
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
Thanks @schneems. It looks like #25426 had the same railties test fail (https://travis-ci.org/rails/rails/jobs/138415607#L1368). #25436 looks like it's trying to fix this issue.
The actioncable tests are failing intermittently for me locally. I don't think it's an ordering issue, I can re-run the actioncable suite with the same seed and have it pass most of the time, but still fail occasionally. I assume it's some kind of concurrency related issue.