Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding implicitly rendered template digests to ETags #25546

Closed

Conversation

javan
Copy link
Contributor

@javan javan commented Jun 27, 2016

Fixes that modifying an implicitly rendered template for a controller action using fresh_when or stale? would not result in a new ETag value.

New test failing without this change:

$ bundle exec rake test  TEST=test/controller/render_test.rb
Run options: --seed 9680

# Running:

.......S..........................F.........................

Finished in 0.212498s, 282.3556 runs/s, 1416.4839 assertions/s.

  1) Failure:
EtagRenderTest#test_etag_reflects_implicit_template_digest [.../actionpack/test/controller/render_test.rb:558]:
Expected response to be a <200: ok>, but was a <304: Not Modified>.
Expected: 200
  Actual: 304

60 runs, 301 assertions, 1 failures, 0 errors, 1 skips

/cc @jeremy

end
end
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@javan javan force-pushed the fix-implicit-render-etag-template-digest branch from 3b67d3e to 9038871 Compare June 28, 2016 03:39
@javan javan force-pushed the fix-implicit-render-etag-template-digest branch from 9038871 to eda71d2 Compare June 28, 2016 12:35
@jeremy
Copy link
Member

jeremy commented Jun 28, 2016

Squashed @ 893fc51 and backported to 5-0-stable @ 1955fa9

@jeremy jeremy closed this Jun 28, 2016
@jeremy jeremy added this to the 5.0.1 milestone Jun 28, 2016
kaspth referenced this pull request Jul 2, 2016
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
philipqnguyen added a commit to philipqnguyen/rails that referenced this pull request Sep 23, 2016
claudiob added a commit that referenced this pull request Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants