Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Serialize JSON attribute value nil as SQL NULL, not JSON 'null' #25670
When loading data from the database both
When data are persisted into the DB
One way to fix this bug is to translate
Support for JSON types in Postgresql in Rails 4.x translates
I think the preferred fix is to map
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
We just ran into this bug in a newly upgraded Rails 5 application. Previously
Would be great to get this fix included in 5.0.1!