Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow rake notes to work with other directories. #25692
The SourceAnnotationExtractor currently has no way of extracting notes from directories other than the predefind directories (app, config, db, lib, test).
The trouble is I would like to be able to extract notes from other folders in the project such as the
This pull request will allow you/gems to register other directories with the SourceAnnotationExtractor.
Currently it is possible to register file extensions. So why not directories?
Registers additional directories to be included
$ rake notes app/spec/models/article_spec.rb: *  [TODO] add more specs *  [FIXME] Spec A is broken *  [OPTIMIZE] improve this test
also discussed here #25576
Additional directories can be added using
Result: rake notes will now extract notes from these directories.
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.