Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Stop changes to a dupped `ActionController::Parameters` mutating the original #25735
This fixes the bug by defining a private
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @chancancode (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
changed the title from
Changes to a dupped `ActionController::Parameters` mutate the original
Stop changes to a dupped `ActionController::Parameters` mutating the original
Jul 7, 2016
I imagine that may not have been true while this class inherited from Hash.
If you can confirm it works the same without it (and that we have test coverage to back that up), this seems like a good opportunity to clean up, before we make things look even more complicated, with a custom