Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly return `associated_table` when `associated_with?` is true #25767

Conversation

@kamipo
Copy link
Member

kamipo commented Jul 10, 2016

AssociationQueryHandler requires association initialized
TableMetadata even if table_name == arel_table.name.

Fixes #25689.

`AssociationQueryHandler` requires `association` initialized
`TableMetadata` even if `table_name == arel_table.name`.

Fixes #25689.
@rails-bot
Copy link

rails-bot commented Jul 10, 2016

r? @matthewd

(@rails-bot has picked a reviewer for you, use r? to override)

@rafaelfranca rafaelfranca merged commit 70ec7fe into rails:master Jul 28, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rafaelfranca added a commit that referenced this pull request Jul 28, 2016
…_join_table_name

Correctly return `associated_table` when `associated_with?` is true
@kamipo kamipo deleted the kamipo:association_name_is_the_same_as_join_table_name branch Jul 28, 2016
@rafaelfranca
Copy link
Member

rafaelfranca commented Jul 28, 2016

Backported in e54e4ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.