New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise ArgumentError for bad strptime arguments #25793

Merged
merged 1 commit into from Jul 12, 2016

Conversation

Projects
None yet
5 participants
@jmondo
Contributor

jmondo commented Jul 12, 2016

Fix ActiveSupport::TimeZone#strptime. Now raises ArgumentError when the given time doesn't match the format. The error is the same as the one given by Ruby's Date.strptime.

Previously it raised NoMethodError: undefined method empty? for nil:NilClass. due to a bug.
Fixes #25701.

@rails-bot

This comment has been minimized.

rails-bot commented Jul 12, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jmondo

This comment has been minimized.

Contributor

jmondo commented Jul 12, 2016

Seemed sensible to raise the same way ruby does. If returning nil is preferred I'm happy to update.

@jmondo

This comment has been minimized.

Contributor

jmondo commented Jul 12, 2016

Oh also is this something worth backporting?

@rafaelfranca rafaelfranca merged commit 2afd5e7 into rails:master Jul 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request Jul 12, 2016

Merge pull request #25793 from jmondo/strptime
Raise ArgumentError for bad strptime arguments
@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Jul 12, 2016

Backported in 2ce7185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment