New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding implicitly rendered namespaced template digests to ETags #25817

Merged
merged 1 commit into from Jul 13, 2016

Conversation

Projects
None yet
3 participants
@javan
Member

javan commented Jul 13, 2016

Extends the fix from #25546 to namespaced controllers and their templates.

New test failing without this change:

$ bundle exec rake test TEST=test/controller/render_test.rb 
Run options: --seed 59446

# Running:

.....S...............................F.......................

Finished in 0.498034s, 122.4816 runs/s, 614.4159 assertions/s.

  1) Failure:
NamespacedEtagRenderTest#test_etag_reflects_template_digest [.../actionpack/test/controller/render_test.rb:611]:
Expected response to be a <200: ok>, but was a <304: Not Modified>.
Expected: 200
  Actual: 304

61 runs, 306 assertions, 1 failures, 0 errors, 1 skips

/cc @jeremy

@javan javan added the actionpack label Jul 13, 2016

@maclover7

This comment has been minimized.

Member

maclover7 commented Jul 13, 2016

On a quick glance, this looks like it could be related to #20333?

@javan

This comment has been minimized.

Member

javan commented Jul 13, 2016

Yeah, looks like the same issue, but could be referencing an older implementation. Either way, this should fix #20333.

@rafaelfranca rafaelfranca merged commit 853a041 into rails:master Jul 13, 2016

2 checks passed

codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Jul 13, 2016

Backported in e3a43ec

rafaelfranca added a commit that referenced this pull request Jul 13, 2016

Merge pull request #25817 from javan/fix-namespaced-implicit-render-e…
…tag-template-digest

Fix adding implicitly rendered namespaced template digests to ETags

philipqnguyen added a commit to philipqnguyen/rails that referenced this pull request Sep 23, 2016

claudiob added a commit that referenced this pull request Sep 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment