Fix bug in method AR TimeZoneConverter#set_time_zone_without_conversion #25834
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
alpaca-tc
changed the title
|
Could you add a CHANGELOG entry? |
|
Could you squash your commits? |
alpaca-tc
force-pushed the
alpaca-tc:fixes_multiparameter_attributes_on_time_with_time_zone_aware_attributes
branch
|
@rafaelfranca i see |
alpaca-tc
force-pushed the
alpaca-tc:fixes_multiparameter_attributes_on_time_with_time_zone_aware_attributes
branch
…butes and invalid params
alpaca-tc
force-pushed the
alpaca-tc:fixes_multiparameter_attributes_on_time_with_time_zone_aware_attributes
branch
to
7805350
rafaelfranca
added a commit
that referenced
this pull request
Jul 20, 2016
…tes_on_time_with_time_zone_aware_attributes Fix bug in method AR TimeZoneConverter#set_time_zone_without_conversion
alpaca-tc
deleted the
alpaca-tc:fixes_multiparameter_attributes_on_time_with_time_zone_aware_attributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Summary
Multi-parameter attributes conversion with invalid params doesn't work when
time_zone_aware_attributesis enabled, because when invalid params is given to Multi-parameter attributes conversion,set_time_zone_without_conversionis assigned tonil.