New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`FinderMethods` uses `records` (`load_target`) when `loaded?` is true #25941

Merged
merged 1 commit into from Jul 28, 2016

Conversation

Projects
None yet
5 participants
@kamipo
Member

kamipo commented Jul 24, 2016

No description provided.

@rails-bot

This comment has been minimized.

rails-bot commented Jul 24, 2016

r? @arthurnn

(@rails-bot has picked a reviewer for you, use r? to override)

@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Jul 28, 2016

Is this fixing any issue?

@kamipo kamipo force-pushed the kamipo:finder_methods_uses_load_target branch to fe48c97 Jul 28, 2016

@kamipo

This comment has been minimized.

Member

kamipo commented Jul 28, 2016

If delegate find_nth to scope, never use loaded target. I added a test case.

@rafaelfranca rafaelfranca merged commit b37bd3d into rails:master Jul 28, 2016

2 checks passed

codeclimate Code Climate has skipped analysis of this commit.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request Jul 28, 2016

Merge pull request #25941 from kamipo/finder_methods_uses_load_target
`FinderMethods` uses `records` (`load_target`) when `loaded?` is true
@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Jul 28, 2016

Backported in b37bd3d

@kamipo kamipo deleted the kamipo:finder_methods_uses_load_target branch Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment