Remove sanitize_conditions and use sanitize_sql instead of sanitize_conditions#25999
Merged
rafaelfranca merged 1 commit intorails:masterfrom Aug 19, 2016
Merged
Conversation
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
kamipo
force-pushed
the
remove_sanitize_conditions
branch
from
e8c4df8 to
64c7758
Compare
Member
There was a problem hiding this comment.
While it is only used internally in one place it is a public API method. Could you add a deprecation message and a CHANGELOG entry?
Member
Author
There was a problem hiding this comment.
This is a protected method. Should we add a CHANGELOG entry?
Member
There was a problem hiding this comment.
Yes, it is documented in http://api.rubyonrails.org/classes/ActiveRecord/Sanitization/ClassMethods.html#method-i-sanitize_conditions, so it is public API.
Member
Author
There was a problem hiding this comment.
Oh... I see. I'll add a CHANGELOG entry later.
Because `sanitize_conditions` protected method is only used in one place.
kamipo
force-pushed
the
remove_sanitize_conditions
branch
from
64c7758 to
6eaf5c9
Compare
Member
Author
|
I added a deprecation message and a CHANGELOG entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
sanitize_conditionsprotected method is only used in one place.