Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow specifying encoding of parameters by action #26092
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.
I'm slightly unsure about making this [only] action-specific; seems likely one might have a few well-known parameter names that are differently-encoded application wide. But I guess we can consider that later, if it starts to feel onerous.
Looks like we need a test to prove they are in fact action specific, though... AFAICS, the current tests would pass if we ignored
Yeah, I had considered adding that, but it wasn't something we were using or needing ATM. Practically speaking, there were only 2-3 action/param combos that needed this.