Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify use of update task on 4.2 and earlier [ci skip] #26176

merged 1 commit into from Aug 15, 2016


Copy link

@stomar stomar commented Aug 15, 2016

A small clarification in the upgrade guides:

The update task has to be invoked with "rake rails:update" for 4.2 and earlier, but the current guide gives the impression "rails rails:update" would work (instead of "rails app:update" for 5.0, like shown in the example).

At least that's what I kept trying for some time (with admittedly only a very basic knowledge of Rails).

Copy link

@rails-bot rails-bot commented Aug 15, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@vipulnsward vipulnsward merged commit c8d9a11 into rails:master Aug 15, 2016
1 check passed
1 check passed
codeclimate Code Climate didn't find any new or fixed issues.
@stomar stomar deleted the stomar:clarify-update-task branch Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants