New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes touch_later respects no_touching policy #26183

Merged
merged 1 commit into from Aug 16, 2016

Conversation

Projects
None yet
5 participants
@casperisfine

casperisfine commented Aug 16, 2016

touch_later doesn't really respect no_touching. It will write attributes regardless of the policy, and then might or might not update the db depending wether the no_touching block is outside or inside the transaction block.

This PR makes it behave a bit more consistently.

cc @rafaelfranca @sgrif

@rails-bot

This comment has been minimized.

rails-bot commented Aug 16, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @arthurnn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit 149c144 into rails:master Aug 16, 2016

2 checks passed

codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafaelfranca rafaelfranca deleted the Shopify:fix-no-touching-touch-later branch Aug 16, 2016

rafaelfranca added a commit that referenced this pull request Aug 16, 2016

Merge pull request #26183 from Shopify/fix-no-touching-touch-later
Makes touch_later respects no_touching policy
@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Aug 16, 2016

Backported in c644e8b

@arthurnn

This comment has been minimized.

Member

arthurnn commented Aug 16, 2016

👍 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment