New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Active Job guide on default runner. #26214

Merged
merged 1 commit into from Aug 18, 2016

Conversation

Projects
None yet
5 participants
@philnash
Contributor

philnash commented Aug 18, 2016

The immediate runner is no longer default, the async adapter is.

I have questions about this though. Should there be a note for people still dealing with Rails 4 that the immediate runner was the default then? Or do the guides always refer to the latest version of Rails?

This is my first documentation contribution, if it works I may need a crack at docrails.

[ci skip] Updates ActiveJob guide on default runner.
The immediate runner is no longer default, the async adapter is.
@rails-bot

This comment has been minimized.

rails-bot commented Aug 18, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@claudiob

This comment has been minimized.

Member

claudiob commented Aug 18, 2016

@philnash You are referring to 625baa6 I assume

@philnash

This comment has been minimized.

Contributor

philnash commented Aug 18, 2016

@claudiob Yup, just seemed that this bit of the guides was overlooked. The async adapter is even referred to further down the page.

@claudiob claudiob merged commit 47ff483 into rails:master Aug 18, 2016

1 check passed

codeclimate Code Climate didn't find any new or fixed issues.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment