New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with Action Cable Redis dependency #26249

Merged
merged 1 commit into from Aug 22, 2016

Conversation

Projects
None yet
5 participants
@rafamanzo
Contributor

rafamanzo commented Aug 22, 2016

Summary

This updates the guides page with development dependencies installation for Action Cable.

Without this the following test for Action Cable fails:

bundle exec ruby -w -Itest test/subscription_adapter/redis_test.rb

Other Information

I've checked the installation instructions for Arch, Ubuntu and Fedora through VirtualBox. OS X, FreeBSD and CentOS I've just searched google on how to install there.

[ci skip] Update docs with Action Cable Redis dependency
Action Cable's test `test/subscription_adapter/redis_test.rb` fail if
Redis is not installed and running.

Following the guides `development_dependen there's no mention to this.
@rails-bot

This comment has been minimized.

rails-bot commented Aug 22, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit 3bfd352 into rails:master Aug 22, 2016

1 check passed

codeclimate Code Climate didn't find any new or fixed issues.
Details

@rafamanzo rafamanzo deleted the rafamanzo:add_redis_to_development_dependencies branch Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment