Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve #tag_option performance #26254
After running stackprof on my production application homepage I noticed that
I performed some tests with
I also benchmarked this change and
I noticed as well that by freezing the string literals I was able to extract a little bit more of performance when an array of values is passed.
Given that this is an internal method and the diff is very trivial I can't see any reason not to change this and have a little performance improvement for free.
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.