Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

travis status image added #2627

Merged
merged 1 commit into from Aug 22, 2011

Conversation

Projects
None yet
4 participants
Contributor

luckydev commented Aug 22, 2011

Lets added the travis build status image to our README. Will be a clear indicator of the status of rails codebase, right in the project repo page.

Owner

fxn commented Aug 22, 2011

Good idea.

Could you please revise the rake task that generates the home page of the API from the README to remove it?

Contributor

luckydev commented Aug 22, 2011

Should I add the image in the api section README as well?

Owner

fxn commented Aug 22, 2011

No, I think the API should not display build status, only the README displayed in GitHub. For historical reasons they are the same modulus details.

@vijaydev vijaydev commented on an outdated diff Aug 22, 2011

Rakefile
@@ -76,6 +76,9 @@ RDoc::Task.new do |rdoc|
rdoc_main.gsub!(/^(?=\S).*?\b(?=Rails)\b/) { "#$&\\" }
rdoc_main.gsub!(%r{link:/rails/rails/blob/master/(\w+)/README\.rdoc}, "link:files/\\1/README_rdoc.html")
+ #remove travis build status image from api pages. Only Github README page gets this image
@vijaydev

vijaydev Aug 22, 2011

Member

nitpicks - s/travis/Travis, s/api/API, s/Github/GitHub

Also, please squash the commits into one. Thanks.

@tenderlove tenderlove added a commit that referenced this pull request Aug 22, 2011

@tenderlove tenderlove Merge pull request #2627 from luckydev/tr
travis status image added
999e7ea

@tenderlove tenderlove merged commit 999e7ea into rails:master Aug 22, 2011

@tenderlove tenderlove merged commit 71232f5 into rails:master Aug 22, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment