Disconnects all connections in the pool before forking. #26314
Conversation
See discussion in puma/puma#1001
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
cc @evanphx |
Seems like good advice. Only matters if initializers make queries. |
If we have the |
I think this is fine. The issue here isn't that the app won't be able to connect to the database but more that the master server will potentially have open connections that aren't being used. For postgres the number of open connections can be a big problem on larger apps. Explicitly disconnecting before forking would prevent any accidentally opened connections from hanging around longer than is needed. |
Please remember "Active Record" has a space. Fixed in 1b6f3a2. |
See puma/puma#1001 and rails/rails#26314 for background.
Taken from this discussion: puma/puma#1001
/cc @schneems