Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make `fixture_file_upload` work in integration tests #26384

Conversation

@y-yagi
Copy link
Member

@y-yagi y-yagi commented Sep 4, 2016

Summary

Currently, fixture_file_upload does not work in integration test.
Because, TestProcess module has been include in Session class, but
fixture_path can not get from Session class.

Modify to include TestProcess in IntegrationTest class in order to get
correct value of fixture_path.

@rails-bot
Copy link

@rails-bot rails-bot commented Sep 4, 2016

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@maclover7 maclover7 added the actionpack label Sep 4, 2016
Currently, `fixture_file_upload` does not work in integration test.
Because, `TestProcess` module has been include in `Session` class, but
`fixture_path` can not get from `Session` class.

Modify to include `TestProcess` in `IntegrationTest` class in order to get
correct value of `fixture_path`.
@y-yagi y-yagi force-pushed the y-yagi:make_fixture_file_upload_in_integration_test branch to 333f10e Sep 4, 2016
@eileencodes eileencodes merged commit 10fcf42 into rails:master Sep 4, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate Code Climate didn't find any new or fixed issues.
Details
@eileencodes
Copy link
Member

@eileencodes eileencodes commented Sep 4, 2016

Awesome! Thank you!

@y-yagi y-yagi deleted the y-yagi:make_fixture_file_upload_in_integration_test branch Sep 4, 2016
@prathamesh-sonpatki
Copy link
Member

@prathamesh-sonpatki prathamesh-sonpatki commented Sep 4, 2016

@eileencodes Should this be backported?

kaspth added a commit that referenced this pull request Sep 8, 2016
…egration_test

make `fixture_file_upload` work in integration tests
@kaspth
Copy link
Member

@kaspth kaspth commented Sep 8, 2016

Backported to 5-0-stable in: 12c629f

@kaspth kaspth removed the needs backport label Sep 8, 2016
matthewd added a commit to matthewd/rails that referenced this pull request Sep 23, 2016
When passed an already-valid file name, prepending the path is likely to
create problems.

This is particularly relevant for rails#26384, which adds fixture_path
handling to test classes that previously didn't have it: any existing
caller must have been manually locating the file, and we don't want to
break them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.