New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for ActiveRecord::Enum#enum when suffix specified #26459

Merged
merged 1 commit into from Sep 12, 2016

Conversation

Projects
None yet
5 participants
@ysksn
Contributor

ysksn commented Sep 11, 2016

Summary

Add some tests when ActiveRecord::Enum#enum called with specific suffix since there was none.

Other Information

Additional tests are testing:

  • class method(scope) is defined and working
  • instance methods are defined and working such as
  • object#enum_name returns its attribute in string
  • #hogehoge! to update
  • #hogehoge? to predicate
@rails-bot

This comment has been minimized.

rails-bot commented Sep 11, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@eileencodes

This comment has been minimized.

Member

eileencodes commented Sep 11, 2016

Thanks for the PR 😄. Can you change "normal" to "medium"? It makes more sense in context.

Add tests for ActiveRecord::Enum#enum when suffix specified
Make name of attribute medium instead of normal
@robin850

This comment has been minimized.

Member

robin850 commented Sep 12, 2016

@ysksn: could yoj please add a comment when you update a pull request ? Otherwise the committers don't get any notification.

@eileencodes: This seems good to merge then. 😊

@ysksn

This comment has been minimized.

Contributor

ysksn commented Sep 12, 2016

@robin850 I get it.
@eileencodes I changed it.

thanks :)

@eileencodes eileencodes merged commit 3dbb371 into rails:master Sep 12, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate Code Climate didn't find any new or fixed issues.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment