New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed guide to add correct documentation for partial render 'as' option #26478

Merged
merged 1 commit into from Sep 13, 2016

Conversation

Projects
None yet
4 participants
@girishso
Contributor

girishso commented Sep 13, 2016

Summary

This PR addresses issue #26286
Reference #26286 (comment)

@rails-bot

This comment has been minimized.

rails-bot commented Sep 13, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@eileencodes eileencodes merged commit 16b1816 into rails:master Sep 13, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate Code Climate didn't find any new or fixed issues.
Details
@eileencodes

This comment has been minimized.

Member

eileencodes commented Sep 13, 2016

Thanks for the PR! 😄

@girishso

This comment has been minimized.

Contributor

girishso commented Sep 14, 2016

@eileencodes Thanks for accepting the PR! :)

@girishso girishso deleted the girishso:fix-guides-for-partial-render-as-option branch Sep 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment