New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address warning: ambiguous first argument #26484

Merged
merged 1 commit into from Sep 13, 2016

Conversation

Projects
None yet
5 participants
@yahonda
Contributor

yahonda commented Sep 13, 2016

Summary

This pull request addresses two warning: ambiguous first argument; put parentheses or a space even after /' operator` warnings:

$ ARCONN=mysql2 bundle exec ruby -w -Itest test/cases/adapters/mysql2/connection_test.rb
test/cases/adapters/mysql2/connection_test.rb:71: warning: ambiguous first argument; put parentheses or a space even after `/' operator
test/cases/adapters/mysql2/connection_test.rb:79: warning: ambiguous first argument; put parentheses or a space even after `/' operator
Using mysql2
Run options: --seed 14025

# Running:

.....................

Finished in 6.240082s, 3.3653 runs/s, 5.7692 assertions/s.

21 runs, 36 assertions, 0 failures, 0 errors, 0 skips
@rails-bot

This comment has been minimized.

rails-bot commented Sep 13, 2016

r? @kaspth

(@rails-bot has picked a reviewer for you, use r? to override)

@rafaelfranca rafaelfranca merged commit a286240 into rails:master Sep 13, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate Code Climate didn't find any new or fixed issues.
Details

@yahonda yahonda deleted the yahonda:mysql2_ambiguous_first_arguments branch Dec 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment