Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug report template for migrations #26488

Merged
merged 3 commits into from Sep 15, 2016

Conversation

@girishso
Copy link
Contributor

@girishso girishso commented Sep 14, 2016

Summary

I had to create this for testing migrations in isolation. Thought it will be helpful in future, without having to dig through the migrations tests.

@rails-bot
Copy link

@rails-bot rails-bot commented Sep 14, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@eileencodes
Copy link
Member

@eileencodes eileencodes commented Sep 14, 2016

Hey @girishso thanks for the PR! Our other bug report templates have a version for the gem and a version for the master branch. Do you mind updating your PR to include both of those?

See the others for how that works: https://github.com/rails/rails/tree/master/guides/bug_report_templates

@prathamesh-sonpatki
Copy link
Member

@prathamesh-sonpatki prathamesh-sonpatki commented Sep 14, 2016

If we are going to add then we need to mention it here as well.

@girishso girishso force-pushed the girishso:test-template-for-migrations branch to b71dd8d Sep 15, 2016
@girishso
Copy link
Contributor Author

@girishso girishso commented Sep 15, 2016

@eileencodes done!

@prathamesh-sonpatki hi there! Done as well!

@prathamesh-sonpatki
Copy link
Member

@prathamesh-sonpatki prathamesh-sonpatki commented Sep 15, 2016

@girishso Can you also squash the commits?


gemfile(true) do
# source "https://rubygems.org"
gem "activerecord"

This comment has been minimized.

@prathamesh-sonpatki

prathamesh-sonpatki Sep 15, 2016
Member

We should use gem "rails", github: "rails/rails" here similar to how it is used in other master bug report templates.

This comment has been minimized.

@girishso

girishso Sep 15, 2016
Author Contributor

Done. Somehow I missed that!

@sevenseacat
Copy link
Contributor

@sevenseacat sevenseacat commented Sep 15, 2016

squashing commits can be done automatically as part of the merge now :)

@eileencodes eileencodes merged commit 084211a into rails:master Sep 15, 2016
2 checks passed
2 checks passed
codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eileencodes
Copy link
Member

@eileencodes eileencodes commented Sep 15, 2016

Thanks @girishso! 👍

(I loveee these new github review features 😍 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.