New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not leak the Errors default proc when calling to_hash or as_json #26640

Merged
merged 1 commit into from Sep 27, 2016

Conversation

Projects
None yet
6 participants
@casperisfine

casperisfine commented Sep 27, 2016

Since b3dfd7d the Hash returned by ActiveModel::Errors#as_json or ActiveModel::Errors#to_hash is coming with the original hash default proc.

It's a regression from 4.2, and I don't see how it could be useful / expected.

@sgrif @rafaelfranca for review please.

@rails-bot

This comment has been minimized.

rails-bot commented Sep 27, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit f2f6a39 into rails:master Sep 27, 2016

2 checks passed

codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafaelfranca rafaelfranca deleted the Shopify:fix-am-errors-to-hash-default-proc branch Sep 27, 2016

@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Sep 27, 2016

Backported in dc5557f

rafaelfranca added a commit that referenced this pull request Sep 27, 2016

Merge pull request #26640 from Shopify/fix-am-errors-to-hash-default-…
…proc

Do not leak the Errors default proc when calling to_hash or as_json

miles-smith added a commit to PublicHealthEngland/ndr_ui that referenced this pull request Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment