Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer writes to the cable sockets #26646

Merged
merged 1 commit into from Sep 30, 2016
Merged

Buffer writes to the cable sockets #26646

merged 1 commit into from Sep 30, 2016

Conversation

@matthewd
Copy link
Member

@matthewd matthewd commented Sep 27, 2016

Sockets can sometimes block, leading to reduced system throughput as threads get tied up.

@FooBarWidget and @tinco helped track this down and review the changes; they've been very kindly sitting on a blog post about it, while I finished this off and proved it, for quite some time 馃様

Otherwise, they can sometimes block, leading to reduced system
throughput.
@tinco
Copy link
Contributor

@tinco tinco commented Sep 27, 2016

Looks good to me :) I think this won't conflict with our own sendbuffer.

@tinco
Copy link
Contributor

@tinco tinco commented Sep 29, 2016

So what happens now, is someone assigned to review this or are you going to merge it yourself after gathering some feedback @matthewd ? I saw #26409 seemed to have been an instance of the problem in the wild which is rather worrying, so I think it's warranted to have this pulled into a release asap.

@matthewd matthewd merged commit 8356dca into rails:master Sep 30, 2016
2 checks passed
matthewd added a commit that referenced this issue Sep 30, 2016
Buffer writes to the cable sockets
@matthewd
Copy link
Member Author

@matthewd matthewd commented Sep 30, 2016

Backported as 56fdc04

@matthewd matthewd deleted the cable-buffer branch Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants