Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
rafaelfranca
added some commits
May 10, 2016
rafaelfranca
added
the
actionpack
label
Oct 10, 2016
rafaelfranca
self-assigned this
Oct 10, 2016
rafaelfranca
added some commits
May 23, 2016
rafaelfranca
force-pushed the
deprecations
branch
to
de9542a
Oct 10, 2016
rafaelfranca
merged commit 0cbb0be
into
master
Oct 10, 2016
rafaelfranca
deleted the
deprecations
branch
Oct 10, 2016
| @@ -620,28 +611,8 @@ def init_with(coder) # :nodoc: | ||
| end | ||
| end | ||
| # Undefine `to_param` such that it gets caught in the `method_missing` | ||
| # deprecation cycle below. | ||
| undef_method :to_param |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rafaelfranca
Oct 10, 2016
Member
I think so. The idea to undef this was to users not call to_param on parameters expecting the hash behavior and getting the to_s result. If we keep it defined it will silently break again and users will have the wrong behavior.
This comment has been minimized.
This comment has been minimized.
connorshea
referenced this pull request
Oct 11, 2016
Merged
Remove deprecations in Active Model, Action View and Active Job #26755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rafaelfranca commentedOct 10, 2016
This the first pass through the codebase to remove deprecations. I chose to open a PR per component to avoid conflicts.
I only left one of the deprecations because I'm not entirely sure how we want to deal with them. The deprecation left is the one added in 6520ea5. @pixeltrix can you push the code that remove the deprecated code in a new branch? I can deal with the broken tests after you push it.
I'm planing to merged as soon the tests are green.