Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all deprecations from Action Pack #26746

Merged
merged 23 commits into from Oct 10, 2016
Merged

Remove all deprecations from Action Pack #26746

merged 23 commits into from Oct 10, 2016

Conversation

@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Oct 10, 2016

This the first pass through the codebase to remove deprecations. I chose to open a PR per component to avoid conflicts.

I only left one of the deprecations because I'm not entirely sure how we want to deal with them. The deprecation left is the one added in 6520ea5. @pixeltrix can you push the code that remove the deprecated code in a new branch? I can deal with the broken tests after you push it.

I'm planing to merged as soon the tests are green.

`skip_action_callback`, `skip_filter`, `before_filter`,
`prepend_before_filter`, `skip_before_filter`,
`append_before_filter`, `around_filter`
`prepend_around_filter`, `skip_around_filter`,
`append_around_filter`, `after_filter`,
`prepend_after_filter`, `skip_after_filter` and
`append_after_filter`.
@rafaelfranca rafaelfranca self-assigned this Oct 10, 2016
rafaelfranca added 14 commits May 23, 2016
ActionDispatch::ParamsParser class was removed in favor of
ActionDispatch::Http::Parameters so it is better to move the error
constant to the new class.
…ic#initialize`
…outing::Mapper#match`
…s in `ActionDispatch::Routing::Mapper#match`
…::IntegrationTest`,

`#process`, `#get`, `#post`, `#patch`, `#put`, `#delete`, and `#head`.
@rafaelfranca rafaelfranca force-pushed the deprecations branch to de9542a Oct 10, 2016
@rafaelfranca rafaelfranca merged commit 0cbb0be into master Oct 10, 2016
3 checks passed
3 checks passed
codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@rafaelfranca rafaelfranca deleted the deprecations branch Oct 10, 2016
Copy link
Member

@kaspth kaspth left a comment

🤘

@@ -620,28 +611,8 @@ def init_with(coder) # :nodoc:
end
end

# Undefine `to_param` such that it gets caught in the `method_missing`
# deprecation cycle below.
undef_method :to_param

This comment has been minimized.

@kaspth

kaspth Oct 10, 2016
Member

Should we still undef this?

This comment has been minimized.

@rafaelfranca

rafaelfranca Oct 10, 2016
Author Member

I think so. The idea to undef this was to users not call to_param on parameters expecting the hash behavior and getting the to_s result. If we keep it defined it will silently break again and users will have the wrong behavior.

This comment has been minimized.

icyflame added a commit to icyflame/cutouts that referenced this pull request Dec 28, 2019
- ActionPack removed the Hash-type methods from the Parameters type:
  - rails/rails#26746
- Visibility's conversion from string to integer for an enum model key
does not work anymore. Not sure about the root cause for this one. Moved
all logic to convert from parameters object to unsafe hash in the helper
module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants