Remove all deprecations from Action Pack #26746

Merged
merged 23 commits into from Oct 10, 2016

Projects

None yet

2 participants

@rafaelfranca
Member

This the first pass through the codebase to remove deprecations. I chose to open a PR per component to avoid conflicts.

I only left one of the deprecations because I'm not entirely sure how we want to deal with them. The deprecation left is the one added in 6520ea5. @pixeltrix can you push the code that remove the deprecated code in a new branch? I can deal with the broken tests after you push it.

I'm planing to merged as soon the tests are green.

rafaelfranca added some commits May 10, 2016
@rafaelfranca rafaelfranca Remove deprecated methods related to controller filters
`skip_action_callback`, `skip_filter`, `before_filter`,
`prepend_before_filter`, `skip_before_filter`,
`append_before_filter`, `around_filter`
`prepend_around_filter`, `skip_around_filter`,
`append_around_filter`, `after_filter`,
`prepend_after_filter`, `skip_after_filter` and
`append_after_filter`.
d7be30e
@rafaelfranca rafaelfranca Remove deprecation at ActionController::BadRequest 6c24e47
@rafaelfranca rafaelfranca Remove deprecated support for status option in head a2762d9
@rafaelfranca rafaelfranca Remove deprecated support to `:back` in `redirect_to` 333bfd8
@rafaelfranca rafaelfranca Remove deprecated support to :nothing in render 57e1c99
@rafaelfranca rafaelfranca Remove deprecated support to :text in render 79a5ea9
@rafaelfranca rafaelfranca Remove deprecated comparing support with `ActionController::Parameters` c396a8c
@rafaelfranca rafaelfranca Remove deprecated methods in ActionController::Parameters 7093ceb
@rafaelfranca rafaelfranca Remove deprecated `xml_http_request` and `xhr` methods 31639ea
@rafaelfranca rafaelfranca self-assigned this Oct 10, 2016
rafaelfranca added some commits May 23, 2016
@rafaelfranca rafaelfranca Remove deprecated support to non-keyword arguments #process 98b8309
@rafaelfranca rafaelfranca Remove deprecated access to mime types through constants 2a3718f
@rafaelfranca rafaelfranca Remove deprecated code in ActionDispatch::ParamsParser::ParseError 1740610
@rafaelfranca rafaelfranca Remove deprecated ActionDispatch::ParamsParser 53d2b73
@rafaelfranca rafaelfranca Deprecated ActionDispatch::ParamsParser::ParamsParser
ActionDispatch::ParamsParser class was removed in favor of
ActionDispatch::Http::Parameters so it is better to move the error
constant to the new class.
b3d41ea
@rafaelfranca rafaelfranca Remove deprecated code in ActionDispatch::Session::SessionRestoreError 2ca83c4
@rafaelfranca rafaelfranca Remove deprecated code in ssl middleware fda5afe
@rafaelfranca rafaelfranca Remove deprecated support to passing strings to the middleware stack 1b975e6
@rafaelfranca rafaelfranca Remove deprecated `cache_control` argument from `ActionDispatch::Stat…
…ic#initialize`
a3ff9db
@rafaelfranca rafaelfranca Remove deprecated support passing path as `nil` in `ActionDispatch::R…
…outing::Mapper#match`
5860b35
@rafaelfranca rafaelfranca Remove deprecated support for passing `:path` and route path as sting…
…s in `ActionDispatch::Routing::Mapper#match`
9185b68
@rafaelfranca rafaelfranca Remove deprecated `ActionDispatch::IntegrationTest#xml_http_request` eb52e5d
@rafaelfranca rafaelfranca Remove deprecated `ActionDispatch::IntegrationTest#*_via_redirect`. 092033d
@rafaelfranca rafaelfranca Remove deprecated support to non-keyword arguments in `ActionDispatch…
…::IntegrationTest`,

`#process`, `#get`, `#post`, `#patch`, `#put`, `#delete`, and `#head`.
de9542a
@rafaelfranca rafaelfranca merged commit 0cbb0be into master Oct 10, 2016

3 checks passed

codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@rafaelfranca rafaelfranca deleted the deprecations branch Oct 10, 2016
@@ -620,28 +611,8 @@ def init_with(coder) # :nodoc:
end
end
- # Undefine `to_param` such that it gets caught in the `method_missing`
- # deprecation cycle below.
undef_method :to_param
@kaspth
kaspth Oct 10, 2016 Member

Should we still undef this?

@rafaelfranca
rafaelfranca Oct 10, 2016 Member

I think so. The idea to undef this was to users not call to_param on parameters expecting the hash behavior and getting the to_s result. If we keep it defined it will silently break again and users will have the wrong behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment