New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations in Active Model, Action View and Active Job #26755

Merged
merged 5 commits into from Oct 11, 2016

Conversation

Projects
None yet
4 participants
@rafaelfranca
Member

rafaelfranca commented Oct 11, 2016

One more round of deprecations removal.

rafaelfranca added some commits Oct 10, 2016

Removed deprecated methods in ActiveModel::Errors
`#get`, `#set`, `[]=`, `add_on_empty` and `add_on_blank`.

@rafaelfranca rafaelfranca merged commit c2fa536 into rails:master Oct 11, 2016

2 checks passed

codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafaelfranca rafaelfranca deleted the rafaelfranca:deprecations branch Oct 11, 2016

@connorshea

This comment has been minimized.

Contributor

connorshea commented Oct 11, 2016

Should this and #26746 have the 5.1.0 milestone?

@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Oct 11, 2016

We don't use milestone to put PRs in a bucket, only if the PR blocks the release and it is not reviewed yet.

@artur-beljajev

This comment has been minimized.

artur-beljajev commented on d1fc0a5 Dec 23, 2017

@rafaelfranca Perhaps input param name_or_adapter_or_class of a method queue_adapter= would be better named name_or_adapter (given that class passing has been removed)?

Same might apply to interpret_adapter method.

This comment has been minimized.

Member

kamipo replied Jan 5, 2018

Fixed in 5a50146. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment