Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations in Active Model, Action View and Active Job #26755

Merged
merged 5 commits into from Oct 11, 2016

Conversation

@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Oct 11, 2016

One more round of deprecations removal.

…ror`.
…rror
…pter
`#get`, `#set`, `[]=`, `add_on_empty` and `add_on_blank`.
@rafaelfranca rafaelfranca merged commit c2fa536 into rails:master Oct 11, 2016
2 checks passed
2 checks passed
@rafaelfranca
codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rafaelfranca rafaelfranca deleted the rafaelfranca:deprecations branch Oct 11, 2016
@connorshea
Copy link
Contributor

@connorshea connorshea commented Oct 11, 2016

Should this and #26746 have the 5.1.0 milestone?

@rafaelfranca
Copy link
Member Author

@rafaelfranca rafaelfranca commented Oct 11, 2016

We don't use milestone to put PRs in a bucket, only if the PR blocks the release and it is not reviewed yet.

@artur-beljajev

This comment has been minimized.

Copy link
Contributor

@artur-beljajev artur-beljajev commented on d1fc0a5 Dec 23, 2017

@rafaelfranca Perhaps input param name_or_adapter_or_class of a method queue_adapter= would be better named name_or_adapter (given that class passing has been removed)?

Same might apply to interpret_adapter method.

This comment has been minimized.

Copy link
Member

@kamipo kamipo replied Jan 5, 2018

Fixed in 5a50146. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants