Support i18n key at translation of value in submit tag #26799

deraru · 2016-10-16T12:46:47Z

Summary

Currently submit tag value translation does not support i18n key style
locale key.
It confuses me a bit because many other components support i18n key
style locale key.
I added i18n key style locale key support to submit tag.

rails-bot · 2016-10-16T12:46:48Z

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @chancancode (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rafaelfranca · 2016-10-16T20:09:17Z

Could you explain better what is not supported now? For what I could see by the code i18n is supported

deraru · 2016-10-16T23:25:26Z

I try to write code example.

class RichBlog::PoorPost << ActiveRecord::Base
end

en:
  activerecord:
    models:
      rich_blog/poor_post: blog post
    attributes:
      rich_blog/poor_post:
        title: post title
  helpers:
    submit:
      rich_blog_poor_post:
        create: Post my post

activerecord.models and activerecord.attributes (and more) keys allow rich_blog/poor_post.
But helpers.submit key does not allow rich_blog/poor_post.

rafaelfranca

Thanks! It make sense to me. Could you add a test case and a CHANGELOG entry?

rafaelfranca · 2016-10-16T23:33:20Z

actionview/lib/action_view/helpers/form_helper.rb

@@ -1879,6 +1879,7 @@ def submit_default_value
          end

          defaults = []
+          defaults << :"helpers.submit.#{object.model_name.i18n_key}.#{key}" if object.respond_to?(:model_name)


Instead of adding a new lookup can we add the :"helpers.submit.#{object.model_name.i18n_key}.#{key}" if it object responds to model_name and defaults << :"helpers.submit.#{object_name}.#{key}" if it doesn't?

What should I think about specification of :as option?
If :as option is given to form_for method, is it prior than actual model name in translation?
For example,

class Blog::Post << ActiveRecord::Base end

form_for @blog_post, as: :my_post do |f| f.submit end

en: helpers: submit: "blog/post": create: Post blog post my_post: create: Post my post

Then which value is expected Post blog post or Post my post?

rafaelfranca · 2016-10-16T23:38:36Z

actionview/lib/action_view/helpers/form_helper.rb

@@ -1879,6 +1879,7 @@ def submit_default_value
          end

          defaults = []
+          defaults << :"helpers.submit.#{object.model_name.i18n_key}.#{key}" if object.respond_to?(:model_name)


Instead of adding a new lookup can we add the :"helpers.submit.#{object.model_name.i18n_key}.#{key}" if it object responds to model_name and defaults << :"helpers.submit.#{object_name}.#{key}" if it doesn't?

deraru · 2016-10-16T23:47:05Z

Could you add a test case and a CHANGELOG entry?

Got it!

m5o · 2016-10-25T13:50:51Z

i18n-debug is very useful to debug/visualize which translations are being looked up by Rails

Just in case you didn't know this handy helper 🤓

deraru · 2016-10-26T14:30:46Z

@rafaelfranca Could you reply to #26799 (comment) ?
I think https://github.com/rails/rails/blob/v5.0.0.1/actionview/test/template/form_helper_test.rb#L2217-L2229 is conflicting test case.

deraru · 2016-12-02T03:57:39Z

@rafaelfranca Any update on this?

deraru · 2017-01-01T06:40:07Z

actionview/lib/action_view/helpers/form_helper.rb

@@ -2248,7 +2248,12 @@ def submit_default_value
          end

          defaults = []
-          defaults << :"helpers.submit.#{object_name}.#{key}"
+          # Object is a model and it is not overwritten by as and scope option.
+          if object.respond_to?(:model_name) && object_name.to_s == model.downcase


Consider :as and :scope option is the top priority for i18n key.

deraru · 2017-01-01T06:41:47Z

actionview/test/template/form_helper/form_with_test.rb

@@ -917,7 +920,7 @@ def test_submit_without_object_and_locale_strings
    end
  end

-  def test_submit_with_object_and_nested_lookup
+  def test_submit_with_object_which_is_overwritten_by_scope_option


Not modified existing tests.

deraru · 2017-01-01T06:43:56Z

actionview/test/template/form_helper/form_with_test.rb

@@ -931,6 +934,21 @@ def test_submit_with_object_and_nested_lookup
    end
  end

+  def test_submit_with_object_which_is_namespaced


Add new test about code that I implemented.

deraru · 2017-01-01T07:00:06Z

@rafaelfranca Could you review again?

deraru · 2017-02-22T00:39:24Z

@rafaelfranca Hello. Any updates on this?

deraru · 2018-02-27T02:03:40Z

@rafaelfranca Hello, what should I do for this?

rafaelfranca · 2018-02-27T02:33:53Z

Sorry, I dropped the ball here. Can you squash your commits and rebase this branch? The code looks good.

deraru · 2018-02-27T02:36:37Z

Thank you 😄 Got it!

…odule_name/class_name Currently submit_tag value translation does not support i18n key style locale key. It confuses me a bit because many other components support i18n key style locale key. I added i18n key style locale key support to submit tag.

deraru · 2018-02-27T05:00:10Z

Wow! I'm so happy because this is a my first time Rails contribution!
Thank you @rafaelfranca !

rafaelfranca · 2018-02-27T05:09:40Z

Thank YOU! And welcome to the list of contributors http://contributors.rubyonrails.org/contributors/rui-onodera/commits

seppsepp · 2023-03-02T16:39:36Z

@deraru Thanks for your contribution. I'm wondering why this feature does not work as expected for me ...

I got the following namespaced model Attempts::RandomAttempt:

class Attempt < ApplicationRecord
end

class Attempts::RandomAttempt < Attempt
end

In the view helper for the default submit value the code does not reach this line:

https://github.com/rails/rails/blob/main/actionview/lib/action_view/helpers/form_helper.rb#L2682

This line would produce the expected lookup key en.helpers.submit.attempts/random_attempt.create. But one line up i the code the condition object_name.to_s == model.downcase is false because object_name is "attempts_random_attempt" and model is "Random attempt".

That's why the code proceeds with the line defaults << :"helpers.submit.#{object_name}.#{key}" and the lookup key becomes en.helpers.submit.attempts_random_attempt.create with an underscore after attempts which is not expected as far as I understood.

I'm by far not familiar enough with Rails to come up with a better condition in line https://github.com/rails/rails/blob/main/actionview/lib/action_view/helpers/form_helper.rb#L2681 but the current one seems to be too exclusive. Maybe @rafaelfranca can assist?

I'm looking forward to your reply. Thanks a lot in advance.

I'm using Rails 7.0.4.2 btw.

seppsepp · 2023-03-02T22:04:26Z

For example line https://github.com/rails/rails/blob/main/actionview/lib/action_view/helpers/form_helper.rb#L2674 could be changed from object.model_name.human to object.model_name.param_key which preserves the namespace which otherwise human would remove. I have to admit it feels a bit weird to use a params related method there ¯\_(ツ)_/¯ . I let the ActionView form_helper tests run and they pass with this change.

rails-bot assigned chancancode Oct 16, 2016

maclover7 added the actionview label Oct 16, 2016

rafaelfranca requested changes Oct 16, 2016

View reviewed changes

deraru force-pushed the support-i18n-key-in-submit-tag branch 3 times, most recently from 8a93d72 to 3bdd0f5 Compare October 24, 2016 07:17

deraru force-pushed the support-i18n-key-in-submit-tag branch from 3bdd0f5 to ce9661b Compare January 1, 2017 06:12

deraru commented Jan 1, 2017

View reviewed changes

rafaelfranca assigned rafaelfranca and unassigned chancancode Jan 1, 2017

maclover7 added the needs feedback label Feb 22, 2017

deraru force-pushed the support-i18n-key-in-submit-tag branch from ce9661b to e579c74 Compare February 27, 2018 02:44

rafaelfranca approved these changes Feb 27, 2018

View reviewed changes

rafaelfranca merged commit f86b221 into rails:master Feb 27, 2018

deraru deleted the support-i18n-key-in-submit-tag branch February 27, 2018 05:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support i18n key at translation of value in submit tag #26799

Support i18n key at translation of value in submit tag #26799

deraru commented Oct 16, 2016

rails-bot commented Oct 16, 2016

rafaelfranca commented Oct 16, 2016

deraru commented Oct 16, 2016

rafaelfranca left a comment

rafaelfranca Oct 16, 2016

deraru Oct 25, 2016 •

edited

Loading

rafaelfranca Oct 16, 2016

deraru commented Oct 16, 2016

m5o commented Oct 25, 2016

deraru commented Oct 26, 2016

deraru commented Dec 2, 2016

deraru Jan 1, 2017

deraru Jan 1, 2017

deraru Jan 1, 2017

deraru commented Jan 1, 2017

deraru commented Feb 22, 2017

deraru commented Feb 27, 2018

rafaelfranca commented Feb 27, 2018

deraru commented Feb 27, 2018

deraru commented Feb 27, 2018

rafaelfranca commented Feb 27, 2018

seppsepp commented Mar 2, 2023 •

edited

Loading

seppsepp commented Mar 2, 2023 •

edited

Loading

Support i18n key at translation of value in submit tag #26799

Support i18n key at translation of value in submit tag #26799

Conversation

deraru commented Oct 16, 2016

Summary

rails-bot commented Oct 16, 2016

rafaelfranca commented Oct 16, 2016

deraru commented Oct 16, 2016

rafaelfranca left a comment

Choose a reason for hiding this comment

rafaelfranca Oct 16, 2016

Choose a reason for hiding this comment

deraru Oct 25, 2016 • edited Loading

Choose a reason for hiding this comment

rafaelfranca Oct 16, 2016

Choose a reason for hiding this comment

deraru commented Oct 16, 2016

m5o commented Oct 25, 2016

deraru commented Oct 26, 2016

deraru commented Dec 2, 2016

deraru Jan 1, 2017

Choose a reason for hiding this comment

deraru Jan 1, 2017

Choose a reason for hiding this comment

deraru Jan 1, 2017

Choose a reason for hiding this comment

deraru commented Jan 1, 2017

deraru commented Feb 22, 2017

deraru commented Feb 27, 2018

rafaelfranca commented Feb 27, 2018

deraru commented Feb 27, 2018

deraru commented Feb 27, 2018

rafaelfranca commented Feb 27, 2018

seppsepp commented Mar 2, 2023 • edited Loading

seppsepp commented Mar 2, 2023 • edited Loading

deraru Oct 25, 2016 •

edited

Loading

seppsepp commented Mar 2, 2023 •

edited

Loading

seppsepp commented Mar 2, 2023 •

edited

Loading