Wait for file events to propagated for slower Listen backends. #26829
Conversation
Listen, when used on JRuby, does have have access to synchronous filesystem events. Instead, it uses a listen loop which has some delay in registering filesystem changes. These tests checked for events to have fired immediately after making filesystem changes, which did not allow time for that listen loop to trigger. I added `wait` to each test, as a few already did, to ensure the events fire. With these changes, the tests are all green on JRuby.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @chancancode (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
|
tenderlove
merged commit 94a14a3
into
rails:5-0-stable
Wait for file events to propagated for slower Listen backends.
Summary
The tests for filesystem events ("checker" or "listen") do not wait for the
Listenevent loop to catch up with changes. This patch adds the waits, so they'll run green on platforms whereListenhas some delay.Other Information
On JRuby, the
listenlibrary does not have access to synchronous filesystem events, a larb_fseventand similar libraries. Instead, it uses a listen loop that may introduce some delay after filesystem changes before an event is fired. Other tests here usedwaitto wait for those changes to propagate, so I added the same wait to the remaining tests. With this change, these tests are green on JRuby.