Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for file events to propagated for slower Listen backends. #26829



Copy link

@headius headius commented Oct 19, 2016


The tests for filesystem events ("checker" or "listen") do not wait for the Listen event loop to catch up with changes. This patch adds the waits, so they'll run green on platforms where Listen has some delay.

Other Information

On JRuby, the listen library does not have access to synchronous filesystem events, a la rb_fsevent and similar libraries. Instead, it uses a listen loop that may introduce some delay after filesystem changes before an event is fired. Other tests here used wait to wait for those changes to propagate, so I added the same wait to the remaining tests. With this change, these tests are green on JRuby.

Listen, when used on JRuby, does have have access to synchronous
filesystem events. Instead, it uses a listen loop which has some
delay in registering filesystem changes. These tests checked for
events to have fired immediately after making filesystem changes,
which did not allow time for that listen loop to trigger. I added
`wait` to each test, as a few already did, to ensure the events
fire. With these changes, the tests are all green on JRuby.
Copy link

@rails-bot rails-bot commented Oct 19, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @chancancode (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Copy link

@rails-bot rails-bot commented Oct 19, 2016

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against 5-0-stable. Please double check that you specified the right target!
@tenderlove tenderlove merged commit 94a14a3 into rails:5-0-stable Oct 19, 2016
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
tenderlove added a commit that referenced this pull request Oct 19, 2016
Wait for file events to propagated for slower Listen backends.
@headius headius deleted the headius:wait_for_events_in_listen_tests branch Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants