Join GitHub today
Explicitly unpack the expanded args to avoid execution order diff. #26854
In https://bugs.ruby-lang.org/issues/12860 I argue that MRI's
This patch makes the unpacking order explicit with a multi-assign,
This code appears to have been introduced after the most recent Rails release so I don't think it needs to be backported. I started running into the "proc to symbol" errors only after switching to master for JRuby testing.
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.