GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The default arg of index_name_exists? is only used the adapter does
not implemented indexes. But currently all adapters implemented
indexes (See #26688). Therefore the default arg is never used.
(@rails-bot has picked a reviewer for you, use r? to override)
Can we deprecate this argument?
Does anyone actually use this method externally? When I added the index_exists? (and column_exists?) methods in 11ff3da I renamed this method from index_exists? because it seemed to only be used internally at the time and was added as part of a general refactoring of add_index and remove_index in 99bcce7. I was wandering whether the whole method should be deprecated and made private?
I added the deprecation message.
The `default` arg of `index_name_exists?` makes to optional
The `default` arg of `index_name_exists?` is only used the adapter does
not implemented `indexes`. But currently all adapters implemented
`indexes` (See #26688). Therefore the `default` arg is never used.
Deprecate passing `default` to `index_name_exists?`