The default arg of index_name_exists? makes to optional
#26930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @chancancode (@rails-bot has picked a reviewer for you, use r? to override) |
rafaelfranca
requested changes
Oct 29, 2016
| # as there's no way to determine the correct answer in that case. | ||
| def index_name_exists?(table_name, index_name, default) | ||
| return default unless respond_to?(:indexes) | ||
| def index_name_exists?(table_name, index_name, default = nil) |
There was a problem hiding this comment.
Can we deprecate this argument?
There was a problem hiding this comment.
Does anyone actually use this method externally? When I added the index_exists? (and column_exists?) methods in 11ff3da I renamed this method from index_exists? because it seemed to only be used internally at the time and was added as part of a general refactoring of add_index and remove_index in 99bcce7. I was wandering whether the whole method should be deprecated and made private?
kamipo
force-pushed
the
index_name_exists_default
branch
from
3951f70 to
16d2239
Compare
kamipo
commented
Nov 3, 2016
| def index_name_exists?(table_name, index_name, default = nil) | ||
| unless default.nil? | ||
| ActiveSupport::Deprecation.warn(<<-MSG.squish) | ||
| Passing default to #index_name_exists? is deprecated without replacement. |
There was a problem hiding this comment.
I added the deprecation message.
kamipo
force-pushed
the
index_name_exists_default
branch
2 times, most recently
from
914ef90 to
a5f2e4b
Compare
kamipo
force-pushed
the
index_name_exists_default
branch
2 times, most recently
from
80f1c9e to
d31a104
Compare
kamipo
force-pushed
the
index_name_exists_default
branch
from
d31a104 to
70cfd76
Compare
kamipo
force-pushed
the
index_name_exists_default
branch
from
70cfd76 to
272b1db
Compare
kamipo
force-pushed
the
index_name_exists_default
branch
from
272b1db to
830f196
Compare
kamipo
force-pushed
the
index_name_exists_default
branch
3 times, most recently
from
3ba087f to
d99ce24
Compare
kamipo
force-pushed
the
index_name_exists_default
branch
from
d99ce24 to
1e424b1
Compare
kamipo
force-pushed
the
index_name_exists_default
branch
2 times, most recently
from
75eae94 to
2739378
Compare
The `default` arg of `index_name_exists?` is only used the adapter does not implemented `indexes`. But currently all adapters implemented `indexes` (See rails#26688). Therefore the `default` arg is never used.
kamipo
force-pushed
the
index_name_exists_default
branch
from
2739378 to
28dc6d7
Compare
rafaelfranca
approved these changes
Feb 13, 2017
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Feb 13, 2017
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
defaultarg ofindex_name_exists?is only used the adapter doesnot implemented
indexes. But currently all adapters implementedindexes(See #26688). Therefore thedefaultarg is never used.