Don't put db:migrate and db:setup in binfiles if activerecord is excluded #26950

Merged
merged 1 commit into from Nov 1, 2016

Projects

None yet

5 participants

@bouk
Member
bouk commented Nov 1, 2016

Summary

Currently bin/setup and bin/update always include db:setup and db:migrate, which makes them fail if active record is skipped. This PR excludes those lines if active record is skipped.

@bouk bouk Don't put db:migrate and db:setup in binfiles if activerecord is excl…
…uded
de08be6
@rails-bot

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@sgrif sgrif merged commit 7bb28a0 into rails:master Nov 1, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codeclimate Code Climate didn't find any new or fixed issues.
Details
@bouk bouk deleted the bouk:exclude-dbmigrate branch Nov 1, 2016
@maclover7 maclover7 added the railties label Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment