Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't put db:migrate and db:setup in binfiles if activerecord is excluded #26950

merged 1 commit into from Nov 1, 2016


Copy link

@bouk bouk commented Nov 1, 2016


Currently bin/setup and bin/update always include db:setup and db:migrate, which makes them fail if active record is skipped. This PR excludes those lines if active record is skipped.

Copy link

@rails-bot rails-bot commented Nov 1, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@sgrif sgrif merged commit 7bb28a0 into rails:master Nov 1, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
codeclimate Code Climate didn't find any new or fixed issues.
@bouk bouk deleted the bouk:exclude-dbmigrate branch Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants