Upgrade JRuby to satisfy gemfile #26990

merged 1 commit into from Nov 7, 2016


None yet

6 participants

kirs commented Nov 7, 2016 edited


Resolving dependencies.....................................................
ruby_dep-1.5.0 requires ruby version >= 2.2.5, which is incompatible with the
current version, ruby 2.2.3p0 (jruby
The command "eval bundle install --without test --jobs 3 --retry 3 --path=${BUNDLE_PATH:-vendor/bundle}" failed. Retrying, 2 of 3.

ruby_dep 1.5.0 requires ruby >=2.2.5. This is something that jruby- doesn't provide.

This PR upgrades the .travis.yml to jruby-

@kirs kirs Upgrade JRuby to satisfy gemfile
@schneems schneems was assigned by rails-bot Nov 7, 2016

r? @schneems

(@rails-bot has picked a reviewer for you, use r? to override)

kirs commented Nov 7, 2016

I can merge this if @headius approves 😊

kirs commented Nov 7, 2016

I'm also wondering why do we only run jruby tests for ActionPack, but not
for other gems.

On Nov 7, 2016 10:11 AM, "Guillermo Iguaran" notifications@github.com

I can merge this if @headius https://github.com/headius approves 😊

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#26990 (comment), or mute
the thread

rafaelfranca commented Nov 7, 2016 edited

Because Rails test suite were not green with any component and we didn't want to slow down our builds because of a implementation of Ruby which we didn't officially support at the time. As soon they are all green I'm totally fine to add. But there is a requirement, the test suite can't be slowed down.

@rafaelfranca rafaelfranca merged commit 1de3041 into rails:master Nov 7, 2016

2 checks passed

codeclimate Code Climate didn't find any new or fixed issues.
continuous-integration/travis-ci/pr The Travis CI build passed
@maclover7 maclover7 added the JRuby label Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment