Upgrade JRuby to satisfy gemfile #26990

Merged
merged 1 commit into from Nov 7, 2016

Projects

None yet

6 participants

@kirs
Contributor
kirs commented Nov 7, 2016 edited

https://travis-ci.org/rails/rails/jobs/173621075#L271

Resolving dependencies.....................................................
ruby_dep-1.5.0 requires ruby version >= 2.2.5, which is incompatible with the
current version, ruby 2.2.3p0 (jruby 9.0.5.0)
The command "eval bundle install --without test --jobs 3 --retry 3 --path=${BUNDLE_PATH:-vendor/bundle}" failed. Retrying, 2 of 3.

ruby_dep 1.5.0 requires ruby >=2.2.5. This is something that jruby-9.0.5.0 doesn't provide.

This PR upgrades the .travis.yml to jruby-9.1.5.0.

@kirs kirs Upgrade JRuby to satisfy gemfile
7a7b23f
@schneems schneems was assigned by rails-bot Nov 7, 2016
@rails-bot

r? @schneems

(@rails-bot has picked a reviewer for you, use r? to override)

@kirs
Contributor
kirs commented Nov 7, 2016
@guilleiguaran
Member

I can merge this if @headius approves 😊

@kirs
Contributor
kirs commented Nov 7, 2016

I'm also wondering why do we only run jruby tests for ActionPack, but not
for other gems.

On Nov 7, 2016 10:11 AM, "Guillermo Iguaran" notifications@github.com
wrote:

I can merge this if @headius https://github.com/headius approves 😊


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#26990 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAf3q5GicPeaOm3GBQH1x_KLpS4LL07Xks5q72nggaJpZM4KrgLA
.

@rafaelfranca
Member
rafaelfranca commented Nov 7, 2016 edited

Because Rails test suite were not green with any component and we didn't want to slow down our builds because of a implementation of Ruby which we didn't officially support at the time. As soon they are all green I'm totally fine to add. But there is a requirement, the test suite can't be slowed down.

@rafaelfranca rafaelfranca merged commit 1de3041 into rails:master Nov 7, 2016

2 checks passed

codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maclover7 maclover7 added the JRuby label Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment